changing dependency requirements #61
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caret notation in poetry allows for a range but the range is too small. For example, for `pandas ="^1.5.3"` this would allow for >=1.5.3 <2.0.0 but the current version is 2.2.2. Poetry also allows for the <= notation so this seems like a better solution, which is why I went with it in my PR.
Merged
|
Sticking with caret so that if a dependency upgrades its major version (which could be breaking), it does not cause issues. I've upgraded the python deps in #64 to the latest versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caret notation in poetry allows for a range but the range is too small. For example, for
pandas ="^1.5.3"this would allow for >=1.5.3 <2.0.0 but the current version is 2.2.2. Poetry also allows for the <= notation so this seems like a better solution, which is why I went with it in my PR.