Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] [Speaker] Company Logo of Deepa #292

Merged
merged 1 commit into from
Dec 7, 2023
Merged

[Fix] [Speaker] Company Logo of Deepa #292

merged 1 commit into from
Dec 7, 2023

Conversation

tirth-multipl
Copy link
Contributor

@tirth-multipl tirth-multipl commented Dec 6, 2023

Screenshot 2023-12-07 at 1 58 36 AM

Comapany-Logo of Deepa looks broken because it was set to empty-string - 47d11a4.

Screenshot 2023-12-07 at 1 59 51 AM

may be it can be fixed by using company-placeholder.png (also being used for Bhoomi's company-url). pardon me if the PR fix is not right, we can close my PR as invalid.

@tirth-multipl tirth-multipl changed the base branch from main to develop December 6, 2023 20:27
@JaldeepAsodariya
Copy link
Member

Perfect. Thanks @tirth-multipl

@JaldeepAsodariya JaldeepAsodariya merged commit 6849b73 into GDGAhmedabad:develop Dec 7, 2023
1 check passed
@tirth-multipl tirth-multipl deleted the fix/deepa_company_logo branch December 7, 2023 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants