fix: revealer animation folding #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanLovato
reviewed
Jan 5, 2022
ui/components/Revealer.gd
Outdated
Comment on lines
144
to
145
| func _animate_height(property: String, from: float) -> void: | ||
| _tween.interpolate_property(self, property, from, _height, ANIM_DURATION) |
There was a problem hiding this comment.
I´d rather not have functions with only one instruction. Here, it mostly requires you to jump somewhere else in the file to understand how the code works - you're not reusing enough code to justify the indirection. I'll change this and merge shortly.
|
Thanks, that's a great fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements:
Related issue (if applicable): #
#104
Also fix folding if animation disabled.