Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content: fix starting_code for lesson 28 #845

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Conversation

theuerc
Copy link
Contributor

@theuerc theuerc commented Jul 24, 2023

Please check if the PR fulfills these requirements:

  • The commit message follows our guidelines.
  • For bug fixes and features:
    • You tested the changes.

Related issue (if applicable): #844

What kind of change does this PR introduce?
Changes [] to Vector2(1, 1) in the starting code for lesson 28.

Does this PR introduce a breaking change?
No

What is the current behavior?
The starting code has [], but the tests check for Vector2(1, 1). And the solution uses Vector2(1, 1) as well.

What is the new behavior?
The starting code has Vector2(1, 1)

@NathanLovato
Copy link
Contributor

The intention was to have random values that you have to fix, but I see this makes it so values in the start script are shuffled instead. It's fine by me, thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants