Update BoidsMovement.json #1286
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update 0.2.3: - fix activate/deactivate behavior not working.
|
Thanks for the fix 🙏 |
D8H
requested changes
May 19, 2024
Comment on lines
-746
to
+756
| "runtimeScene.__boidsExtension.boidsManager.remove(behavior);" | ||
| "behavior.activated = 0;" |
There was a problem hiding this comment.
By removing this line, deactivated Boids will stays in the R-Tree and will continue to have side effect on other Boids.
A behavior already have a activated() accessor, but it's not needed. What should probably be done is to remove the Boids from boids.
There was a problem hiding this comment.
that's the error, by removing the boid from the R-tree it forgets its original behavior when reactivated, so my solution is to pause and then resume it when needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue reference: https://forum.gdevelop.io/t/boids-extension-doesnt-work-anymore-after-deactivate-it/57526/3
Update 0.2.3: