Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ManifestDPIaware and CRCCheck settings #182

Merged
merged 1 commit into from
Apr 11, 2020
Merged

Conversation

ikreb7
Copy link
Contributor

@ikreb7 ikreb7 commented Mar 16, 2020

Changes:

  • put Compress settings on the top
  • add CRCCheck
  • add ManifestDPIaware
  • remove XPStyle

The ManifestDPIaware is important that the installer text is not blurry anymore. But you have to use at least nsis3.0.

@ikreb7
Copy link
Contributor Author

ikreb7 commented Apr 11, 2020

Status?

@twoln twoln merged commit e76b451 into GEANT:master Apr 11, 2020
@twoln
Copy link
Contributor

twoln commented Apr 17, 2020

ManifestDPIAware true breaks down graphics scaling on my Windows VM running on a Mac (nonstandard magnification set in Windows). According to documentation image scaling problem is a known issue, so I guess we should not set this option.

@ikreb7
Copy link
Contributor Author

ikreb7 commented Apr 17, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants