Tiogia TPL Update / Build Fixes #2485
Conversation
wrtobin
commented
May 25, 2023
•
wrtobin
commented
- Update to more recent tioga TPLs (Tiogia TPL Update / Build Fixes LvArray#288)
- Fix tioga fmt link-time error
- Add tioga to nightly gitlab CI so we have at least a modicum of HIP/ROCM automated CI coverage (https://github.com/GEOS-DEV/nightlyTests/pull/7)
wrtobin
added
type: feature
| @@ -35,7 +35,7 @@ void stringToInputVariable( Tensor< T, SIZE > & target, string const & inputValu | |||
| std::istringstream ss( inputValue ); | |||
| auto const errorMsg = [&]( auto const & msg ) | |||
| { | |||
| return GEOS_FMT( "{} for Tensor<{}> at position {} in input: {}", msg, SIZE, ss.tellg(), inputValue ); | |||
| return GEOS_FMT( "{} for Tensor<{}> at position {} in input: {}", msg, SIZE, static_cast< int >( ss.tellg() ), inputValue ); | |||
There was a problem hiding this comment.
Something about the tellg return type isn't handled appropriately by CCE on tioga using the more modern fmt libraray, but by the standard it is convertible to integer types, so this resolves the compile failure.
There was a problem hiding this comment.
This is good fix for the future in general, since std::fpos is not required by the standard to have a std::formatter specialization
| ``ENABLE_DOCS`` ``ON`` Build documentation (Sphinx and Doxygen) | ||
| ``ENABLE_WARNINGS_AS_ERRORS`` ``ON`` Treat all warnings as errors | ||
| ``ENABLE_PVTPackage`` ``ON`` Enable PVTPackage library (required for compositional flow runs) | ||
| ``ENABLE_TOTALVIEW_OUTPUT`` ``OFF`` Enables TotalView debugger custom view of GEOS data structures | ||
| ``GEOS_ENABLE_TESTS`` ``ON`` Enables unit testing targets |
There was a problem hiding this comment.
This was supposed to be in the unit test PR, but managed to be forgotten.
|
tioga needs to be added here to "paths" so gitlab will save the created folder of artifacts for nightlyTests. Lines 91 to 98 in 461dadf Additionally, on the nightlyTests repository side of things, some scripting files need to modified so the tioga artifacts will be scraped and front-facing README updated: Text file keeping track of when different phases were last passing. Entries need to be added for tioga, expected by the Add tioga to list of systems. |
|
@bmhan12 Just opened a PR on nightlyTests with the noted changes: https://github.com/GEOS-DEV/nightlyTests/pull/7 |
|
Would it break anything in the gitlab CI if altered the sha1 hashes in last_passed to |
Nope, no verification. In the past, I think I've put TBD or similar placeholder for when it has never passed before. |
wrtobin
added
ci: run CUDA builds
|
I was hoping to merge this just now but had a 3 hour timeout because of course. If I'm unable to merge it later on tonight and someone else gets to it first, once it goes in we can merge the nightlyTests PR linked above (it shouldn't go in first since it isn't a submodule and depends on this PR being merged to function correctly). |
