Modified parallel plates permeability and updated discretization

[karimifard]

• Parallel plates permeability is now defined as ($a^2 /12$) instead of ($a^3 /12$) to be consistent with the other permeability models and the thermal discretization.
• All TPFA discretizations are updated to be consistent with this change, this includes the update of stencil weights during the simulation when the hydraulic aperture changes.
• In addition, the discretization for flow exchange between fracture and matrix is updated to account for fracture properties.
• Small bug fix in Carman Kozeny permeability formula.

IntegratedTests PR: GEOS-DEV/integratedTests#37

[CusiniM]

@karimifard I have fixed that last compilation error on gpu machines. I am not too sure why but nvcc does not like whenever we call a device lambda nested inside a generic lambda. Maybe @klevzoff has a better idea of why that's not allowed. In any case, I have moved the kernel launches to FlowSolverBaseKernels.hpp and that seems to fix the issue on our gpu machine. If it passes the CI, I think this PR can be moved to the merge queue.

[klevzoff]

I am not too sure why but nvcc does not like whenever we call a device lambda nested inside a generic lambda. Maybe @klevzoff has a better idea of why that's not allowed.

I'm not too sure either, probably something to do with ABI and how the device lambda names are mangled. In any case, it's intentionally not supported by nvcc, so moving these kernel launches to a non-lambda context is the correct workaround.

[karimifard]

Thanks @CusiniM @klevzoff everything seems to work 👍
Just for information (not related to this PR) the latest develop does not compile with clang anymore. I had to switch to gcc.

[herve-gross]

Just for information (not related to this PR) the latest develop does not compile with clang anymore. I had to switch to gcc.

Same problem on my side, related to an explicit move operator requiring an explicit destructor:

In file included from /Users/hervegross/Documents/code/GEOS/src/coreComponents/dataRepository/WrapperBase.hpp:24:
/Users/hervegross/Documents/code/GEOS/src/coreComponents/dataRepository/xmlWrapper.hpp:160:3: error: explicitly defaulted move constructor is implicitly deleted [-Werror,-Wdefaulted-function-deleted]
  xmlDocument( xmlDocument && ) = default;
  ^
/Users/hervegross/Documents/code/GEOS/src/coreComponents/dataRepository/xmlWrapper.hpp:259:22: note: move constructor of 'xmlDocument' is implicitly deleted because field 'pugiDocument' has an inaccessible move constructor
  pugi::xml_document pugiDocument;

[CusiniM]

Just for information (not related to this PR) the latest develop does not compile with clang anymore. I had to switch to gcc.

Same problem on my side, related to an explicit move operator requiring an explicit destructor:

In file included from /Users/hervegross/Documents/code/GEOS/src/coreComponents/dataRepository/WrapperBase.hpp:24:
/Users/hervegross/Documents/code/GEOS/src/coreComponents/dataRepository/xmlWrapper.hpp:160:3: error: explicitly defaulted move constructor is implicitly deleted [-Werror,-Wdefaulted-function-deleted]
  xmlDocument( xmlDocument && ) = default;
  ^
/Users/hervegross/Documents/code/GEOS/src/coreComponents/dataRepository/xmlWrapper.hpp:259:22: note: move constructor of 'xmlDocument' is implicitly deleted because field 'pugiDocument' has an inaccessible move constructor
  pugi::xml_document pugiDocument;

yeah, there is a fix for this: #2654