-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Log level documentation on SolverBase and children #3230
Conversation
@CusiniM I just updated my branch with pavel's pr, it should looks good now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please figure out what can be done with line break for residuals output, otherwise it should be good to go
and there are few places in wave solvers that I didn't really touch but they should be changed for consistency |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- You may have forgotten
SourceFluxStatistics
&SolverStatistics
(withlogInfo::Statistics
)
src/coreComponents/physicsSolvers/contact/ContactSolverBase.cpp
Outdated
Show resolved
Hide resolved
src/coreComponents/physicsSolvers/fluidFlow/wells/CompositionalMultiphaseWell.cpp
Outdated
Show resolved
Hide resolved
src/coreComponents/physicsSolvers/fluidFlow/CompositionalMultiphaseStatistics.cpp
Outdated
Show resolved
Hide resolved
src/coreComponents/physicsSolvers/fluidFlow/SinglePhaseStatistics.cpp
Outdated
Show resolved
Hide resolved
this was around the top of the queue, no? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@victorapm 's requests seem to be adressed as well as mines, so I think this PR is right to be merged.
There will be a follow-up PR for the other messages.
This PR is the first iteration to document all
logLevel
in GEOS and to invite the contributors to set descriptions when they enable thelogLevel
wrapper:In the first iteration, the work of this PR would be limited to
Solverbase
and itschildren
.Currently, we have this output in all
Group
documentation files:This PR allows to add more context to all
logLevels
of GEOS:I.e.
SolidMechanics_LagrangianFEM.rst
:In this PR, both of the mechanism will exists at the same times, the old one will be marked as
deprecated
. The upcoming PR will remove it and document all other groups.