Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Using enums" #22

Merged
merged 1 commit into from
Jun 12, 2020
Merged

Revert "Using enums" #22

merged 1 commit into from
Jun 12, 2020

Conversation

TotoGaz
Copy link
Collaborator

@TotoGaz TotoGaz commented Jun 12, 2020

Some indices consistency needs to be done carefully.
This reverts commit b239ac5
See comments b239ac5#r39869430

@TotoGaz
Revert "Using enums"
ce6b836 
This reverts commit b239ac5
@TotoGaz TotoGaz requested a review from herve-gross June 12, 2020 20:18
herve-gross
herve-gross approved these changes Jun 12, 2020
View reviewed changes
Copy link
Contributor

@herve-gross herve-gross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK to revert - just be aware that the current code is not necessarily correct (some involuntary index changes take place)

@TotoGaz
Copy link
Collaborator Author

TotoGaz commented Jun 12, 2020

OK to revert - just be aware that the current code is not necessarily correct (some involuntary index changes take place)

Yes, I will consider this in the global refactoring.
I'm always very uncomfortable working without tests validating the intended behavior.

@TotoGaz TotoGaz merged commit 0c4bb09 into master Jun 12, 2020
@TotoGaz TotoGaz deleted the bugfix/TotoGaz/revert_indices branch June 12, 2020 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@herve-gross herve-gross herve-gross approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TotoGaz @herve-gross