Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for FORD Testing #1570

Merged
merged 4 commits into from
Jun 16, 2022
Merged

Updates for FORD Testing #1570

merged 4 commits into from
Jun 16, 2022

Conversation

mathomp4
Copy link
Member

Description

Testing with the FORD Documentation maker found a few changes needed to support FORD. These included adding a program statement to the top of a few programs (that only had an end), removing pfio/pfio_io_demo.F90 (see #1567) and fixing a macro redefinition.

Related Issue

Closes #1567

Motivation and Context

Let's me try out FORD with MAPL!

How Has This Been Tested?

I don't see how any of these changes should break the model. Pretty trivial

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@mathomp4 mathomp4 added 📝 Documentation Improvements or additions to documentation 0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) labels Jun 15, 2022
@mathomp4 mathomp4 requested a review from a team as a code owner June 15, 2022 17:04
@mathomp4 mathomp4 self-assigned this Jun 15, 2022
tclune
tclune previously approved these changes Jun 15, 2022
@mathomp4
Copy link
Member Author

Re-requesting @tclune review. Apparently I pushed after the review (I removed that pf test that wasn't being run)

@tclune tclune merged commit 9cf12ca into develop Jun 16, 2022
@tclune tclune deleted the feature/mathomp4/updates-for-ford branch June 16, 2022 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) 📝 Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants