Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1687. Stretched Grid checkpoint attributes should be in degrees #1736

Merged
merged 3 commits into from
Oct 17, 2022

Conversation

mathomp4
Copy link
Member

Description

Per #1687 from @LiamBindle, our checkpoints for stretched grid checkpoints are outputting TARGET_LON and TARGET_LAT in radians and not degrees. This PR should fix that.

Related Issue

Closes #1687

Motivation and Context

Solves an issue from our GCHP friends.

How Has This Been Tested?

I compiled and ran it with GEOSgcm. It is trivially zero-diff for GEOS as we do not (yet) use stretched grid. I suppose the real test will be when GCHP can test it.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@mathomp4 mathomp4 added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label Oct 17, 2022
@mathomp4 mathomp4 self-assigned this Oct 17, 2022
@mathomp4 mathomp4 requested a review from a team as a code owner October 17, 2022 14:05
base/NCIO.F90 Outdated Show resolved Hide resolved
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments.

@mathomp4 mathomp4 requested a review from tclune October 17, 2022 15:39
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@lizziel
Copy link
Contributor

lizziel commented Feb 14, 2023

Sorry I was unaware of this issue and fix before today. I just tested it and it still gives problems. I will follow-up at #1977

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enforced stretched grid attributes in internal checkpoint files are in units of radians
3 participants