Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce ESMF version #1857

Merged
merged 5 commits into from
Dec 13, 2022
Merged

Enforce ESMF version #1857

merged 5 commits into from
Dec 13, 2022

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Dec 9, 2022 •
edited
Loading

Description

This PR adds a version to the find_package(ESMF) call in our CMake. This is help prevent issues like #1855 in the future.

I have tested this in a spack build and it seemed to work just fine there as well.

Related Issue

Motivation and Context

Make sure users of MAPL have the right version of ESMF.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@mathomp4 mathomp4 added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label Dec 9, 2022
@mathomp4 mathomp4 self-assigned this Dec 9, 2022
@mathomp4
Copy link
Member Author

With some very ugly hacks to a MAPL spack package, I was able to test this. It worked in Spack, so it is good.

@mathomp4 mathomp4 marked this pull request as ready for review December 13, 2022 14:23
@mathomp4 mathomp4 requested review from a team as code owners December 13, 2022 14:23
@mathomp4 mathomp4 merged commit 706d142 into develop Dec 13, 2022
@mathomp4 mathomp4 deleted the feature/mathomp4/add-esmf-requirement branch December 13, 2022 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tclune tclune tclune approved these changes

Assignees

@mathomp4 mathomp4

Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathomp4 @tclune