Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend OMP layer to support ESMF callback states #1889

Merged
merged 16 commits into from
Jan 4, 2023
Merged

Extend OMP layer to support ESMF callback states #1889

merged 16 commits into from
Jan 4, 2023

Conversation

aoloso
Copy link
Contributor

@aoloso aoloso commented Dec 20, 2022

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@aoloso aoloso added the 🚫 Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs label Dec 20, 2022
@github-actions
Copy link

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: Contingent - DNA

@github-actions
Copy link

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled, github_actions. Found: Contingent - DNA

1 similar comment
@github-actions
Copy link

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled, github_actions. Found: Contingent - DNA

@github-actions
Copy link

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: Contingent - DNA

@github-actions
Copy link

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: Contingent - DNA

@github-actions
Copy link

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled, github_actions. Found: Contingent - DNA

tclune
tclune reviewed Dec 21, 2022
View reviewed changes
generic/CMakeLists.txt Outdated Show resolved Hide resolved
tclune
tclune reviewed Dec 21, 2022
View reviewed changes
generic/OpenMP_Support.F90 Outdated Show resolved Hide resolved
tclune
tclune reviewed Dec 21, 2022
View reviewed changes
generic/OpenMP_Support.F90 Outdated Show resolved Hide resolved
@github-actions
Copy link

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled, github_actions. Found: Contingent - DNA

@github-actions
Copy link

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: Contingent - DNA

@aoloso @tclune
Update generic/MaplGenericComponent.F90
fb1bb65 
Co-authored-by: Tom Clune <thomas.l.clune@nasa.gov>
@github-actions
Copy link

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled, github_actions. Found: Contingent - DNA

@github-actions
Copy link

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: Contingent - DNA

@mathomp4
Copy link
Member

I think I need to look at the label enforcer. It seems a bit...noisy. 😄

@aoloso
working ...
4f62ec9
@aoloso
Merge branch 'feature/aoloso/merge_v10.23.0_MSTRF_GWD_hybrid' of gith…
6567517 
…ub.com:GEOS-ESM/MAPL into feature/aoloso/merge_v10.23.0_MSTRF_GWD_hybrid
@github-actions
Copy link

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: Contingent - DNA

@github-actions
Copy link

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled, github_actions. Found: Contingent - DNA

@github-actions
Copy link

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled, github_actions. Found: Contingent - DNA

@aoloso @tclune
Update generic/OpenMP_Support.F90
6be3815 
Co-authored-by: Tom Clune <thomas.l.clune@nasa.gov>
@github-actions
Copy link

github-actions bot commented Jan 3, 2023

This PR is being prevented from merging because have not added one of our required labels: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled, github_actions. Please add one so that the PR can be merged.

@github-actions
Copy link

github-actions bot commented Jan 3, 2023

This PR is being prevented from merging because you have added one of our blocking labels: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. You'll need to remove it before this PR can be merged.

@aoloso @tclune
Update generic/OpenMP_Support.F90
541d0cc 
Co-authored-by: Tom Clune <thomas.l.clune@nasa.gov>
@github-actions
Copy link

github-actions bot commented Jan 3, 2023

This PR is being prevented from merging because you have added one of our blocking labels: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. You'll need to remove it before this PR can be merged.

@aoloso @tclune
Update generic/OpenMP_Support.F90
b96852d 
Co-authored-by: Tom Clune <thomas.l.clune@nasa.gov>
@github-actions
Copy link

github-actions bot commented Jan 3, 2023

This PR is being prevented from merging because have not added one of our required labels: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled, github_actions. Please add one so that the PR can be merged.

1 similar comment
@github-actions
Copy link

github-actions bot commented Jan 3, 2023

This PR is being prevented from merging because have not added one of our required labels: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled, github_actions. Please add one so that the PR can be merged.

@github-actions
Copy link

github-actions bot commented Jan 3, 2023

This PR is being prevented from merging because you have added one of our blocking labels: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. You'll need to remove it before this PR can be merged.

@aoloso @tclune
Update generic/OpenMP_Support.F90
04427ad 
Co-authored-by: Tom Clune <thomas.l.clune@nasa.gov>
@github-actions
Copy link

github-actions bot commented Jan 3, 2023

This PR is being prevented from merging because you have added one of our blocking labels: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. You'll need to remove it before this PR can be merged.

@github-actions
Copy link

github-actions bot commented Jan 3, 2023

This PR is being prevented from merging because have not added one of our required labels: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled, github_actions. Please add one so that the PR can be merged.

@tclune tclune self-requested a review January 3, 2023 15:35
tclune
tclune previously approved these changes Jan 3, 2023
View reviewed changes
@github-actions
Copy link

github-actions bot commented Jan 3, 2023

This PR is being prevented from merging because have not added one of our required labels: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled, github_actions. Please add one so that the PR can be merged.

@github-actions
Copy link

github-actions bot commented Jan 3, 2023

This PR is being prevented from merging because you have added one of our blocking labels: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. You'll need to remove it before this PR can be merged.

@github-actions
Copy link

github-actions bot commented Jan 4, 2023

This PR is being prevented from merging because you have added one of our blocking labels: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. You'll need to remove it before this PR can be merged.

@github-actions
Copy link

github-actions bot commented Jan 4, 2023

This PR is being prevented from merging because have not added one of our required labels: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled, github_actions. Please add one so that the PR can be merged.

@mathomp4 mathomp4 marked this pull request as ready for review January 4, 2023 15:58
@mathomp4 mathomp4 requested review from a team as code owners January 4, 2023 15:58
@mathomp4 mathomp4 added 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. and removed 🚫 Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs labels Jan 4, 2023
mathomp4
mathomp4 approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@mathomp4 mathomp4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seemed to work when not being used as I ran a C24 case and it was zero-diff. Approve.

@mathomp4 mathomp4 merged commit 887e364 into develop Jan 4, 2023
@mathomp4 mathomp4 deleted the feature/aoloso/merge_v10.23.0_MSTRF_GWD_hybrid branch January 4, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathomp4 mathomp4 mathomp4 approved these changes

@tclune tclune tclune left review comments

Assignees
No one assigned
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aoloso @mathomp4 @tclune