Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2283 - NAG and dangling pointers #2284

Merged
merged 2 commits into from
Aug 1, 2023
Merged

Fixes #2283 - NAG and dangling pointers #2284

merged 2 commits into from
Aug 1, 2023

Conversation

tclune
Copy link
Collaborator

@tclune tclune commented Aug 1, 2023 •
edited by mathomp4
Loading

Description

Related Issue

Motivation and Context

Fixed bugs detected by NAG compiler.

How Has This Been Tested?

Tested with MAPL compilation and unit tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@tclune tclune added 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. bugfix labels Aug 1, 2023
@tclune tclune requested a review from a team as a code owner August 1, 2023 15:54
@mathomp4 mathomp4 requested a review from a team as a code owner August 1, 2023 15:57
mathomp4
mathomp4 approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@mathomp4 mathomp4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zero-diff for GEOS

@mathomp4 mathomp4 merged commit 1afeb43 into main Aug 1, 2023
13 of 14 checks passed
@mathomp4 mathomp4 deleted the hotfix/tclune/#2283-missing-target-nag branch August 1, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathomp4 mathomp4 mathomp4 approved these changes

Assignees
No one assigned
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tclune @mathomp4