Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract multiple field names from var_list expressions in History3g Collection #2802

Merged
merged 18 commits into from
May 2, 2024
Merged

Extract multiple field names from var_list expressions in History3g Collection #2802

merged 18 commits into from
May 2, 2024

Conversation

darianboggs
Copy link
Contributor

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

This extends the ability for to extract multiple field names from items in the History3G Collection var_list. I tested it with all MAPL short tests.

Related Issue

@darianboggs
Support History3G collection item expressions
a9d6163
@darianboggs
Processing of expressions beyond simple fields
4b474e5
@darianboggs
Add temporary workaround converter function.
6658dc5
@darianboggs
Merge branch 'release/MAPL-v3' into feature/wdboggs/generalize_histor…
f4b847d 
…y3g_collection_imports
@darianboggs
Remove unnecessary code; fix converter
1402b7d
@darianboggs
Merge branch 'release/MAPL-v3' into feature/wdboggs/generalize_histor…
d40a975 
…y3g_collection_imports
@darianboggs
Remove "only" for StringVector; move gFTL_StringVector to single
accfe32 
procedure.
@darianboggs
Merge branch 'release/MAPL-v3' into feature/wdboggs/generalize_histor…
ac7e532 
…y3g_collection_imports
@darianboggs
basic_captest and parent_child_captest pass
1f61409
@darianboggs
Update CHANGELOG.md
ca95865
@darianboggs
Merge branch 'release/MAPL-v3' into feature/wdboggs/generalize_histor…
9863bdb 
…y3g_collection_imports
@darianboggs
Update to use gFTLv2 StringVector
7da6ffe
@darianboggs
Update
762d2fd
@darianboggs
Add missing variables
2507e31
@darianboggs
Merge branch 'release/MAPL-v3' into feature/wdboggs/generalize_histor…
6f986e2 
…y3g_collection_imports
@darianboggs
Parse multiple variables in collection expressions.
a2e2f20
@darianboggs
Merge branch 'release/MAPL-v3' into feature/wdboggs/generalize_histor…
4650248 
…y3g_collection_imports
@darianboggs
Eliminate redundant public statements
516734f
@darianboggs darianboggs added the 📈 MAPL3 MAPL 3 Related label May 1, 2024
@darianboggs darianboggs self-assigned this May 1, 2024
@darianboggs darianboggs requested a review from a team as a code owner May 1, 2024 17:31
@darianboggs darianboggs added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label May 1, 2024
@tclune tclune merged commit 01fd5bc into release/MAPL-v3 May 2, 2024
41 of 43 checks passed
@tclune tclune deleted the feature/wdboggs/generalize_history3g_collection_imports branch May 2, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tclune tclune tclune approved these changes

@bena-nasa bena-nasa bena-nasa approved these changes

Assignees

@darianboggs darianboggs

Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@darianboggs @tclune @bena-nasa