Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revist the creation of submodules in geom_mgr #2834

Merged
merged 1 commit into from
May 17, 2024
Merged

Revist the creation of submodules in geom_mgr #2834

merged 1 commit into from
May 17, 2024

Conversation

JulesKouatchou
Copy link
Contributor

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

Revist the creation of submodules in geom_mgr. We particularly focus on the submodules associated with GeomManager.F90 and do the following:

  • Include the function find_factory in its own submodule.
  • Remove all the use statements from all the submodules

Related Issue

@JulesKouatchou
- Include the function find_factory in its own submodule.
b193ee6 
- Remove all the `use` statements from all the submodules
@JulesKouatchou JulesKouatchou added 0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) 📈 MAPL3 MAPL 3 Related Changelog Skip Skips the Changelog Enforcer labels May 17, 2024
@JulesKouatchou JulesKouatchou requested review from a team as code owners May 17, 2024 11:43
@JulesKouatchou JulesKouatchou changed the base branch from main to release/MAPL-v3 May 17, 2024 15:07
@JulesKouatchou
Copy link
Contributor Author

Just changed the base.

@tclune tclune merged commit 309dd71 into release/MAPL-v3 May 17, 2024
50 checks passed
@tclune tclune deleted the MAPL-v3/smods/generic3g/v1_2 branch May 17, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tclune tclune tclune approved these changes

Assignees
No one assigned
Labels
0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) Changelog Skip Skips the Changelog Enforcer 📈 MAPL3 MAPL 3 Related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JulesKouatchou @tclune