Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2969 #2975

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Fixes #2969 #2975

merged 2 commits into from
Aug 20, 2024

Conversation

bena-nasa
Copy link
Collaborator

@bena-nasa bena-nasa commented Aug 19, 2024

Fixes #2969
As requested by @lizziel
Implements what was requested.
Adds a new option to MAPL_AddExportSpec to set a positive attribute in fields. By default all fields are down.

History checks that all fields being written in a collection have same positive attribute and sets this in lev variable. If they do not is an error.

Also took this opportunity to change some _VERIFY(status) macros to _RC in the file I was touching and found some random code that seemed to be unused so thought I'll remove that...

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

Related Issue

@bena-nasa bena-nasa added 🎁 New Feature This is a new feature 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. labels Aug 19, 2024
@bena-nasa bena-nasa requested review from a team as code owners August 19, 2024 14:15
@bena-nasa bena-nasa changed the base branch from main to develop August 19, 2024 14:16
@bena-nasa bena-nasa requested a review from tclune August 19, 2024 14:41
@tclune tclune merged commit b85a39a into develop Aug 20, 2024
48 checks passed
@tclune tclune deleted the feature/bmauer/fixes-#2969 branch August 20, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🎁 New Feature This is a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specify positive attribute when creating state fields
2 participants