Carthage #5
Merged
Carthage #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added macOS and tvOS targets - Updated README.md
- Cleaned up scheme names and removed xcuserdata
- Added Preprocessor target as a Target Dependency to all 3 Platforms
- Updated podspec to support tvOS - Requires a version bump and pod trunk push
|
Looks great. I'm going to bump the version number and make a new release that includes this. |
|
I actually think we need to break with our tradition of following the version numbers from geos itself. Instead, the version numbers we use here will just be for our build config, not for the underlying lib. |
|
Awesome! Also don't forget you can add tvOS support now to the podspec for the next podspec release and it should also update the README.md badge from Cocoapods. |
|
Pushing it now. Trunk pushes were disabled for maintenance on the specs repo when I tried doing it over the weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an Xcode Project and Preprocessing target which builds geos.framework for iOS, macOS and tvOS.
It would be a good idea to add test targets which run the test files and add this to Travis CI or something.