Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement LDAP authentication #198

Merged
merged 3 commits into from
Sep 1, 2022
Merged

Implement LDAP authentication #198

merged 3 commits into from
Sep 1, 2022

Conversation

rinkp
Copy link
Member

@rinkp rinkp commented Aug 22, 2022

No description provided.

@rinkp rinkp requested a review from tomudding August 22, 2022 19:02
tomudding
tomudding requested changes Aug 27, 2022
View reviewed changes
Copy link
Member

@tomudding tomudding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add LDAP_ environment variables (without values and as comments) to the docker-compose.yml file?

@rinkp rinkp requested a review from tomudding August 31, 2022 15:46
@rinkp
Copy link
Member Author

rinkp commented Aug 31, 2022

Can you also add LDAP_ environment variables (without values and as comments) to the docker-compose.yml file?

Done in 885326d

tomudding
tomudding reviewed Aug 31, 2022
View reviewed changes
Copy link
Member

@tomudding tomudding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny thing, but apart from that it looks good.

docker/web/development/Dockerfile Outdated Show resolved Hide resolved
@tomudding tomudding self-requested a review September 1, 2022 15:15
@tomudding tomudding merged commit a6aea01 into GEWIS:master Sep 1, 2022
@rinkp rinkp deleted the feat/ldap branch June 1, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomudding tomudding tomudding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rinkp @tomudding