Implement dynamic configuration service #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rinkp
changed the title
tomudding
approved these changes
May 4, 2024
github-actions bot
added a commit
that referenced
this pull request
May 10, 2024
rinkp: Merge pull request GH-390 from 'rinkp/feat/configmodule' Implement dynamic configuration service Co-authored-by: rinkp <rinkp@users.noreply.github.com>
5 tasks
tomudding
added a commit
to tomudding/gewisdb
that referenced
this pull request
Aug 7, 2024
I am against having the names hard-coded in the e-mails. We previously discussed in GEWISGH-286 that we do not have a better way of doing this, since then we have the new dynamic configuration available that would solve this (GEWISGH-390) but would still require updates each year to ensure the data is up-to-date. Instead, we do a bit less personalisation and a bit more of not hard-coding names and dates.
tomudding
added a commit
to tomudding/gewisdb
that referenced
this pull request
Aug 7, 2024
I am against having the names hard-coded in the e-mails. We previously discussed in GEWISGH-286 that we do not have a better way of doing this, since then we have the new dynamic configuration available that would solve this (GEWISGH-390) but would still require updates each year to ensure the data is up-to-date. Instead, we do a bit less personalisation and a bit more of not hard-coding names and dates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some features, such as the one requested in GH-389, it is preferable if we can store a dynamic configuration through the database engine. This PR introduces a configuration service.
Reading config and default values has been implemented in the API health endpoint. Setting and unsetting is never used, but useful for testing: