-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Proposal] Vulnerability impact object #75
Comments
We haven't specified any codes already for impact.unit? |
In DDH_v0.2.xlsx for the field
Would these be relevant here? There was also a conversation here |
@odscrachel I think those are metrics rather than units. In https://rdl-standard.readthedocs.io/en/sphinx/data_model/loss.html#flood-loss-scenarios-for-afghanistan-2050, the unit is 'USD'. @stufraser1 are impacts and losses always expressed as financial values or are there other types of value and if so please could you provide some examples? QUDT offers an ontology of units, which we might be able to reuse. |
Yes there might be other non-monentary values for |
Ah, I see. Area, % of area and % of total value aren't units exactly. In QUDT terms, they are a mix of quantity kinds (vocabulary) and units (vocabulary):
It gets quite complicated to structure that level of detail and that is probably only necessary if there is a use case for performing calculations based on those fields. Looking at the examples in this issue, I think a better approach might be:
Here's how that would look for each example. Let me know if I missed anything. Area (assuming square metres) {
"impact": {
"metric": {
"type": "absolute",
"description": "Area"
},
"unit": "M2"
}
} % of area {
"impact": {
"metric": {
"type": "relative",
"description": "% of area"
},
"unit": "PERCENT"
}
} % of total value {
"impact": {
"metric": {
"type": "relative",
"description": "% of total value"
},
"unit": "PERCENT"
}
} Annual Average Losses (assuming in USD) {
"impact": {
"metric": {
"type": "absolute",
"description": "Annual average losses"
},
"currency": "USD",
}
} Annual Average Loss Ratio (assuming percent) {
"impact": {
"metric": {
"type": "relative",
"description": "Annual average loss ratio"
},
"unit": "PERCENT"
}
} Probable Maximal Loss (assuming currency) {
"impact": {
"metric": {
"type": "absolute",
"description": "Probable maximal loss"
},
"currency": "USD"
}
} |
This proposal has taken a wrong turn somewhere down the line, we should have clarified this better in the spreadsheet. But vulnerability.impact should refer to the y-axis of a vulnerability function, fragility function, damage-to-loss function (where the hazard parameter is on the x-axis) or vulnerability index.
Refer to vulnerability schema reports and Phase 3 report here https://riskdatalibrary.org/resources |
Agree, Duncan proposal would be more related to the Loss impact object than the V model calculation. |
Ah, apologies, I thought we were aiming for a common model for impact across vulnerability and loss. Looking at the impact metrics in #75 (comment), I still think that we should separate out
QUDT is a very long codelist so we can recommend a subset of its codes. From the examples in this issue, looks like we need:
Does that sound good? Let me know if I misunderstood anything. |
They could be different, as the losses might be a translation of the vulnerability into a different unit.
I don't see the practical advantage, and also find confusing to have empty
Although this would cover most cases, I'm worried we can't really anticipate all possible units. Or can we? |
Is your proposal to model the kind of quantity being measured (time, area, currency etc.) rather than the specific unit in which it is measured (hours, m2, USD etc.)? If so, that seems logical to me, since it should be possible for users to convert between units within a particular kind of quantity (e.g. minutes to hours, m2 to hectares, USD to GBP etc.), but not necessarily possible to convert between different kinds of quantity. However, I would name the field
We can't anticipate all possible quantity kinds, but we can:
|
This can be tricky when it comes to validating data. One possible way to do this is to make the codelist 2-tier, e.g.
But this still isn't easy to validate and potentially confusing... This could be an open codelist with instructions on how to create this compound type of code. An alternative is to create a field for each possible metric and where more than one unit is applicable create a codelist for each. |
See #5 resolution:
|
So, proposing to use open codelists and guidance for Moving to 'agreed and ready' on project board |
***SUPERCEDED Code,Label,Definition |
impact_type.csv Code,Label,Definition |
data_calculation_type.csv Code,Label,Definition EDIT: renamed this as it is also being used in |
@stufraser1 should impact_metric.csv not be "damage ratio, mean damage ratio, probability of exceeding damage limit state, loss ratio, total loss, number of casualties(fatalities), casualty(fatality) ratio, annual average loss, downtime, damage index" as the codes? (or @matamadio as I think Stu might be away for some of this week) |
Yes you're correct. Will revise as soon as I can. |
What is your proposed change?
impact
object to hold all of the impact description fields with the vulnerability component. This object will also appear in the loss component with a slightly different description.impact.unit
impact.base_data_type
impact
impact.type
impact.metric
impact.unit
impact.base_data_type
The text was updated successfully, but these errors were encountered: