add metric object, rename cost_type to metric_type, add quantity_kind… #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncandewhurst
requested changes
Aug 28, 2023
Co-authored-by: Duncan Dewhurst <duncan.dewhurst@opendataservices.coop>
3 tasks
|
@odscjen is this ready to review again? |
|
@duncandewhurst sorry yes I forgot to re-request! |
duncandewhurst
approved these changes
Aug 29, 2023
matamadio
approved these changes
Aug 29, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… codelist
Related issues
closes #194
Description
Merge checklist
./manage.pypre-commitIf you added or removed a field:
collapseoption of the jsonschema directives for dataset, resource, hazard, exposure, vulnerability and loss onreference/schema.mdHaving trouble?
See how to resolve check failures.