Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Environment bugfixes completed & Hypergrid Tests Reworked #30

Merged
merged 5 commits into from
Apr 17, 2023
Merged

Environment bugfixes completed & Hypergrid Tests Reworked #30

merged 5 commits into from
Apr 17, 2023

Conversation

josephdviviano
Copy link
Collaborator

  • Hypergrid environment tested to be working.
  • Environments accept a seed during reset for reproducibility.
  • All tests reworked (no more reliance on print statements but rather assertions).
  • Other misc fixes.

@josephdviviano josephdviviano self-assigned this Apr 14, 2023
saleml
saleml approved these changes Apr 17, 2023
View reviewed changes
Copy link
Collaborator

@saleml saleml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome ! The environment tests look much cleaner

@saleml saleml merged commit 6737496 into generic-gfn Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saleml saleml saleml approved these changes

Assignees

@josephdviviano josephdviviano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josephdviviano @saleml