Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorials for gfn #39

Closed
wants to merge 11 commits into from
Closed

Tutorials for gfn #39

wants to merge 11 commits into from

Conversation

vict0rsch
Copy link
Collaborator

No description provided.

@vict0rsch vict0rsch changed the base branch from generic-gfn to master May 2, 2023 20:15
@vict0rsch vict0rsch marked this pull request as draft May 2, 2023 21:26
@saleml
Copy link
Collaborator

saleml commented May 3, 2023

Looking at how the examples folder is used here (notebooks, and scripts), I think it makes more sense to move examples/[modules,estimators,distributions].py to utils/[...].py.
The classes in the three files are neither examples per se nor core part of the library, but utilitaries that may be helpful for many people.

Thoughts, @vict0rsch @josephdviviano ?

@vict0rsch
Copy link
Collaborator Author

I agree 100% thanks :)

@josephdviviano
Copy link
Collaborator

Yeah that makes sense. examples could be more scripts that stitch all elements together, similar to the example in the README.md.

@vict0rsch vict0rsch changed the base branch from master to generic-gfn May 5, 2023 18:30
@josephdviviano josephdviviano deleted the branch generic-gfn August 2, 2023 01:25
@saleml
Copy link
Collaborator

saleml commented Aug 2, 2023

@vict0rsch Can you change where the branch will be merged to (master), so that it can be reopened ?

@saleml
Copy link
Collaborator

saleml commented Aug 2, 2023

reopen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants