Unused mut warning when using ben_map and ben_list macro #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekhendrickx
changed the title
|
Huh, looks like the nightly channel wasnt emitting this warning, but I did see it on stable. Thanks for the fix! |
GGist
added a commit
that referenced
this pull request
Nov 17, 2017
derekhendrickx
deleted the
fix/bip-bencode-unused-mut-warning-in-macro
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the unused
mutfor the macrosben_mapandben_list. Those were generating a warning from the compiler:warning: variable does not need to be mutable.The related issue is #135.