Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaning code #51

Merged
merged 5 commits into from
Sep 22, 2020
Merged

Cleaning code #51

merged 5 commits into from
Sep 22, 2020

Conversation

bonaparten
Copy link
Contributor

@bonaparten bonaparten commented Sep 21, 2020 •
edited
Loading

making some variables private

FabiKo117
FabiKo117 approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@FabiKo117 FabiKo117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loooks good

@FabiKo117 FabiKo117 merged commit 2d73a28 into master Sep 22, 2020
@FabiKo117 FabiKo117 deleted the cleaning-code branch September 22, 2020 14:46
@tyrasd tyrasd added the code quality Topics around code quality, e.g. refactoring, better naming of methods/classes label Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabiKo117 FabiKo117 FabiKo117 approved these changes

Assignees
No one assigned
Labels
code quality Topics around code quality, e.g. refactoring, better naming of methods/classes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bonaparten @FabiKo117 @tyrasd