Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide response text passthrough for GPX-formatted requests #67

Merged
merged 5 commits into from
Mar 14, 2022
Merged

Provide response text passthrough for GPX-formatted requests #67

merged 5 commits into from
Mar 14, 2022

Conversation

jayaddison
Copy link
Contributor

Resolves #43.

@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2021

Codecov Report

Merging #67 (834e959) into master (ed5e5cd) will decrease coverage by 0.37%.
The diff coverage is 71.42%.

Impacted file tree graph

@@             Coverage Diff             @@
##            master      #67      +/-   ##
===========================================
- Coverage   100.00%   99.62%   -0.38%     
===========================================
  Files           12       12              
  Lines          525      530       +5     
===========================================
+ Hits           525      528       +3     
- Misses           0        2       +2     
Flag Coverage Δ
unittests 99.62% <71.42%> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
openrouteservice/directions.py 100.00% <ø> (ø)
openrouteservice/client.py 98.40% <71.42%> (-1.60%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed5e5cd...834e959. Read the comment docs.

@jayaddison
Copy link
Contributor Author

cc @koebi @MichaelsJP (not urgent; I noticed issue #67 a while ago and figured it'd be worth attempting an implementation)

@MichaelsJP
Copy link
Member

@jayaddison Thx a lot for the contribution. 👌 I'll have a look at it the next days.

@MichaelsJP MichaelsJP self-requested a review March 6, 2022 16:55
@MichaelsJP MichaelsJP self-assigned this Mar 6, 2022
@MichaelsJP MichaelsJP removed their request for review March 6, 2022 16:55
@MichaelsJP MichaelsJP self-requested a review March 14, 2022 10:16
@MichaelsJP MichaelsJP self-requested a review March 14, 2022 10:16
@MichaelsJP MichaelsJP merged commit c764db8 into GIScience:master Mar 14, 2022
@jayaddison
Copy link
Contributor Author

Thanks @MichaelsJP!

@jayaddison jayaddison deleted the issue-43/gpx-format branch March 14, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSONDecodeError when requesting directions in gpx format
3 participants