Add md5 hash as additional return value for all services #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@HendrikLeuschner Is the md5 file read for every request? |
TimMcCauley
suggested changes
Jan 2, 2018
rabidllama
requested changes
Jan 3, 2018
| osm_md5_hash = FileUtility.readFile(md5Files[0].toString()).trim(); | ||
| } | ||
| catch (IOException e) | ||
| {} |
There was a problem hiding this comment.
It might be worth adding an error message to the log if there is a problem reading the md5 files seeing as this is a new feature and so would be easier for debugging. It doesn't need to be sent to the user, just logged.
rabidllama
approved these changes
Jan 3, 2018
TimMcCauley
approved these changes
Jan 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
md5 hash extracted from any single .md5 file with any name in folder 'graphs' and returned as parameter in response of all services.