Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CellIterator: add "lastContributionTimestamp" to OSMEntitySnapshot & decouple from Grid implementation #495

Merged
merged 10 commits into from
Apr 6, 2023

Conversation

tyrasd
Copy link
Member

@tyrasd tyrasd commented Mar 23, 2023

Description

Includes the following aspects of the CellIterator class:

  • return the lastContributionTimestamp for each entity snapshot (i.e. the timestamp when the OSM entity was last touched before the snapshot timestamp)
  • decouple CellIterator from grid implementation: It now accepts an OSHEntitySource (i.e. a stream of OSHEntity object plus the corresponding bounding box) instead of a raw grid cell object. This makes it easier to swap this out in the future with alternative backends that don't rely on this exact implementation of the grid
  • refactor internal "data holding" classes to records

Checklist

@tyrasd tyrasd added the user experience Enhances the usability of OSHDB label Mar 23, 2023
@tyrasd tyrasd requested a review from rtroilo March 23, 2023 15:12
@tyrasd tyrasd marked this pull request as draft March 23, 2023 15:27
@tyrasd tyrasd changed the title CellIterator: add "lastContributionTimestamp" to OSMEntitySnapshot & accept Stream instead of Iterable CellIterator: add "lastContributionTimestamp" to OSMEntitySnapshot & decouple from Grid implementation Mar 23, 2023
@tyrasd tyrasd marked this pull request as ready for review March 23, 2023 16:08
Copy link
Member

@rtroilo rtroilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you 🤗

@tyrasd tyrasd merged commit cbb831d into master Apr 6, 2023
@tyrasd tyrasd deleted the celliterator branch April 6, 2023 10:48
ConstantinNicolai pushed a commit that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user experience Enhances the usability of OSHDB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants