Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequences with unnecessary brackets do not fail well e.g. [LFucp[2Me,4A]a1-2]DGalpb1-OH #135

Open
gitoliver opened this issue Mar 29, 2022 · 2 comments
Assignees

Comments

@gitoliver
Copy link
Contributor

Build via text and put [LFucp[2Me,4A]a1-2]DGalpb1-OH
The Gal isn't generated, instead you get LFucp[2Me,4A]a1-OH, which is not what I would expect. Either the brackets should be ignored, or an error thrown. Low priority as the inputs are technically flawed.

@gitoliver gitoliver added the bug label Mar 29, 2022
@gitoliver gitoliver self-assigned this Mar 29, 2022
@Lachele
Copy link
Member

Lachele commented Mar 29, 2022 via email

@gitoliver
Copy link
Contributor Author

Just noting that it happened as the user was trying to build in the opposite direction. So they clicked Gal first, then OH, and then their only option for adding Fuc was as a branch... So I wonder if we can design the interface better that this doesn't happen. Anyway it would still be ideal if gmml would figure out that the brackets are extraneous by itself, so I'll keep this open as an "enhancement".

@gitoliver gitoliver added enhancement and removed bug labels Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants