Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #2601 when complete #2617

Merged
merged 20 commits into from May 10, 2021
Merged

fixes #2601 when complete #2617

merged 20 commits into from May 10, 2021

Conversation

nathandunn
Copy link
Contributor

@nathandunn nathandunn commented May 7, 2021

fixes #2601

  • create an example text with { go_annotations: [ { } , {} ], provenance: [{ }, {}], gene_product: [{}, {}] }
  • parse and validate (N Go annotations, M provenance, etc.)
  • pipe into REST method to add for each with a report of what was added
  • allow empty for reference and with for GO (and others?) with NOT_PROVIDED:UNKNOWN
  • check allowing others to not be specified, null, etc.
  • allow REST to batch load multiple: promise chain or create a newer save method that can do multiple at once
  • handle update
  • fix add message
  • put button in transcript and gene and ??
  • fix null saves
  • fix with or from via Unknown / Not provided
  • should be included in history does not work, but left hooks in for this
  • fix deletions

@nathandunn nathandunn merged commit 9016b45 into develop May 10, 2021
@nathandunn
Copy link
Contributor Author

FYI @uliboehme and @mbc32

Note: it does not get recorded in history by design because going forwarded, it does not work. Maybe something for a later dev to fix (@garrettjstevens / @rbuels / @peterkxie ) if that functionality is desired.

@cmdcolin cmdcolin deleted the fix-2601 branch December 7, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow upload and download of JSON for functional annotation
1 participant