Fix issue with tagFilter * in alignments track (#4213)

GMOD · Feb 19, 2024 · 39a61ca · 39a61ca
1 parent 75756d5
commit 39a61ca
Show file tree

Hide file tree

Showing 3 changed files with 957 additions and 987 deletions.
diff --git a/plugins/alignments/src/BamAdapter/BamAdapter.ts b/plugins/alignments/src/BamAdapter/BamAdapter.ts
@@ -207,7 +207,11 @@ export default class BamAdapter extends BaseFeatureDataAdapter {
 
           if (tagFilter) {
             const v = record.get(tagFilter.tag)
-            if (!(v === '*' ? v !== undefined : `${v}` === tagFilter.value)) {
+            if (
+              !(tagFilter.value === '*'
+                ? v !== undefined
+                : `${v}` === tagFilter.value)
+            ) {
               continue
             }
           }

diff --git a/plugins/alignments/src/CramAdapter/CramAdapter.ts b/plugins/alignments/src/CramAdapter/CramAdapter.ts
@@ -262,7 +262,11 @@ export default class CramAdapter extends BaseFeatureDataAdapter {
               tagFilter.tag === 'RG'
                 ? this.samHeader.readGroups?.[record.readGroupId]
                 : record.tags[tagFilter.tag]
-            if (!(v === '*' ? v !== undefined : `${v}` === tagFilter.value)) {
+            if (
+              !(tagFilter.value === '*'
+                ? v !== undefined
+                : `${v}` === tagFilter.value)
+            ) {
               continue
             }
           }