Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with tagFilter * in alignments track #4213

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Feb 18, 2024

Was doing an incorrect comparison to the tags value being * instead of the tag filter's value being *

Fixes #4204

Copy link

codecov bot commented Feb 18, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (75756d5) 62.92% compared to head (bf1af79) 62.88%.

Files Patch % Lines
plugins/alignments/src/BamAdapter/BamAdapter.ts 50.00% 1 Missing and 1 partial ⚠️
plugins/alignments/src/CramAdapter/CramAdapter.ts 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4213      +/-   ##
==========================================
- Coverage   62.92%   62.88%   -0.04%     
==========================================
  Files        1071     1071              
  Lines       31193    31199       +6     
  Branches     7449     7455       +6     
==========================================
- Hits        19627    19620       -7     
- Misses      11395    11408      +13     
  Partials      171      171              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmdcolin cmdcolin merged commit 39a61ca into main Feb 19, 2024
10 checks passed
@cmdcolin cmdcolin deleted the tag_filter_star branch February 19, 2024 00:28
@cmdcolin cmdcolin added the bug Something isn't working label Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tag filter for any (*) not working on alignments track
1 participant