Skip to content

Commit

Permalink
Add import/no-extraneous-dependencies rule back to repo (#2385)
Browse files Browse the repository at this point in the history
  • Loading branch information
cmdcolin committed Oct 6, 2021
1 parent 24b45e2 commit ad60c1d
Show file tree
Hide file tree
Showing 9 changed files with 34 additions and 17 deletions.
30 changes: 18 additions & 12 deletions .eslintrc.base.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,15 +28,13 @@
"@typescript-eslint/no-empty-function": "off",
"@typescript-eslint/no-unused-vars": ["warn"],
"@typescript-eslint/no-unused-expressions": "off",
"no-use-before-define": "off",
"@typescript-eslint/no-use-before-define": "off",
"@typescript-eslint/no-var-requires": "off",
"@typescript-eslint/no-redeclare": "off",

"no-use-before-define": "off",
"curly": "error",
"no-global-assign": "warn",
"react/no-danger": "warn",
"import/no-anonymous-default-export": "off",
"monorepo/no-internal-import": "off",
"no-console": [
"warn",
{
Expand All @@ -46,6 +44,12 @@
"no-debugger": "warn",
"no-undef": "error",
"no-underscore-dangle": "warn",

"import/no-extraneous-dependencies": "error",
"import/no-anonymous-default-export": "off",
"monorepo/no-internal-import": "off",

"react/no-danger": "warn",
"react/destructuring-assignment": "error",
"react/no-unused-prop-types": "error",
"react/no-unused-state": "error",
Expand All @@ -59,13 +63,6 @@
}
]
},
"settings": {
"import/resolver": {
"node": {
"extensions": [".js", ".jsx", ".ts", ".tsx"]
}
}
},
"overrides": [
{
"files": ["**/*.ts", "**/*.tsx"],
Expand All @@ -80,7 +77,16 @@
}
},
{
"files": ["**/test/**", "**/*.test.[t,j]s", "**/*.test.[t,j]sx"],
"files": [
"**/test/**",
"**/*.test.[t,j]s",
"**/*.test.[t,j]sx",
"**/rescripts/*",
"**/tests/util.js",
"**/webpack.config.js",
"**/scripts/notarize.js",
"**/src/testUtil.ts"
],
"env": {
"jest": true
},
Expand Down
3 changes: 2 additions & 1 deletion plugins/authentication/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@jbrowse/plugin-authentication",
"version": "1.3.0",
"version": "1.4.4",
"description": "JBrowse 2 Authentication",
"keywords": [
"jbrowse",
Expand Down Expand Up @@ -41,6 +41,7 @@
"peerDependencies": {
"@jbrowse/core": "^1.0.0",
"@material-ui/core": "^4.9.13",
"electron": "^15.0.0",
"mobx": "^5.0.0",
"mobx-react": "^6.0.0",
"mobx-state-tree": "3.14.1",
Expand Down
2 changes: 2 additions & 0 deletions plugins/grid-bookmark/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,13 @@
"useSrc": "node ../../scripts/useSrc.js"
},
"dependencies": {
"file-saver": "^2.0.0",
"@material-ui/icons": "^4.9.1"
},
"peerDependencies": {
"@jbrowse/core": "^1.0.0",
"@jbrowse/plugin-config": "^1.0.0",
"@jbrowse/plugin-linear-genome-view": "^1.4.4",
"@material-ui/core": "^4.9.13",
"@material-ui/data-grid": "^4.0.0-alpha.37",
"@material-ui/lab": "^4.0.0-alpha.45",
Expand Down
3 changes: 2 additions & 1 deletion plugins/legacy-jbrowse/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@
"@gmod/nclist": "^0.1.1",
"get-value": "^3.0.1",
"set-value": "^4.0.1",
"buffer-crc32": "^0.2.13"
"buffer-crc32": "^0.2.13",
"generic-filehandle": "^2.2.0"
},
"peerDependencies": {
"@jbrowse/core": "^1.0.0",
Expand Down
6 changes: 5 additions & 1 deletion products/jbrowse-desktop/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
"dependencies": {
"@jbrowse/core": "^1.4.4",
"@jbrowse/plugin-alignments": "^1.4.4",
"@jbrowse/plugin-authentication": "^1.4.4",
"@jbrowse/plugin-bed": "^1.4.4",
"@jbrowse/plugin-breakpoint-split-view": "^1.4.4",
"@jbrowse/plugin-circular-view": "^1.4.4",
Expand All @@ -62,6 +63,7 @@
"@jbrowse/plugin-sv-inspector": "^1.4.4",
"@jbrowse/plugin-svg": "^1.4.4",
"@jbrowse/plugin-trackhub-registry": "^1.4.4",
"@jbrowse/plugin-trix": "^1.4.4",
"@jbrowse/plugin-variants": "^1.4.4",
"@jbrowse/plugin-wiggle": "^1.4.4",
"@material-ui/core": "^4.12.2",
Expand All @@ -70,6 +72,7 @@
"@material-ui/lab": "^4.0.0-alpha.45",
"clsx": "^1.0.4",
"deepmerge": "^4.2.2",
"electron": "15.0.0",
"electron-debug": "^3.0.1",
"electron-is-dev": "^1.1.0",
"electron-updater": "^4.3.9",
Expand All @@ -88,7 +91,8 @@
"react-error-boundary": "^3.0.0",
"react-sizeme": "^2.6.7",
"rxjs": "^6.5.2",
"timeago.js": "^4.0.2"
"timeago.js": "^4.0.2",
"use-query-params": "1.1.3"
},
"browserslist": [
"last 1 chrome version"
Expand Down
2 changes: 2 additions & 0 deletions products/jbrowse-img/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@
},
"dependencies": {
"@jbrowse/react-linear-genome-view": "^1.4.4",
"@jbrowse/plugin-linear-genome-view": "^1.4.4",
"mobx": "^5.10.1",
"react": "^17.0.1",
"react-dom": "^17.0.1",
"tmp": "^0.2.1",
Expand Down
1 change: 0 additions & 1 deletion products/jbrowse-img/src/index.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
/* eslint-disable no-console */
import 'abortcontroller-polyfill/dist/abortcontroller-polyfill-only'
import fs from 'fs'
import yargs from 'yargs'
import { standardizeArgv, parseArgv } from './parseArgv'
Expand Down
1 change: 0 additions & 1 deletion products/jbrowse-img/src/renderRegion.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import 'regenerator-runtime/runtime'
import { createViewState } from '@jbrowse/react-linear-genome-view'
import { renderToSvg } from '@jbrowse/plugin-linear-genome-view'
import { when } from 'mobx'
Expand Down
3 changes: 3 additions & 0 deletions products/jbrowse-web/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
"dependencies": {
"@jbrowse/core": "^1.4.4",
"@jbrowse/plugin-alignments": "^1.4.4",
"@jbrowse/plugin-authentication": "^1.4.4",
"@jbrowse/plugin-bed": "^1.4.4",
"@jbrowse/plugin-breakpoint-split-view": "^1.4.4",
"@jbrowse/plugin-circular-view": "^1.4.4",
Expand All @@ -38,6 +39,7 @@
"@jbrowse/plugin-sv-inspector": "^1.4.4",
"@jbrowse/plugin-svg": "^1.4.4",
"@jbrowse/plugin-trackhub-registry": "^1.4.4",
"@jbrowse/plugin-trix": "^1.4.4",
"@jbrowse/plugin-variants": "^1.4.4",
"@jbrowse/plugin-wiggle": "^1.4.4",
"@material-ui/core": "^4.12.2",
Expand All @@ -49,6 +51,7 @@
"copy-to-clipboard": "^3.3.1",
"core-js": "^3.2.1",
"crypto-js": "^3.0.0",
"file-saver": "^2.0.0",
"fontsource-roboto": "3.0.3",
"json-stable-stringify": "^1.0.1",
"librpc-web-mod": "^1.1.2",
Expand Down

0 comments on commit ad60c1d

Please sign in to comment.