Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all dependencies are properly specified in package.json files using eslint-plugin-import #2385

Merged
merged 2 commits into from
Oct 6, 2021

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Oct 6, 2021

Fixes #2333
I owe a big debt to ljharb at import-js/eslint-plugin-import#2247 for helping fix this!

We may have had this rule as part of a larger rule bundle at one point but this restores it

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Oct 6, 2021
@cmdcolin cmdcolin merged commit ad60c1d into main Oct 6, 2021
@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Oct 6, 2021
@cmdcolin cmdcolin changed the title Add import/no-extraneous-dependencies back to repo Ensure all dependencies are properly specified in package.json files using eslint-plugin-import Oct 6, 2021
@cmdcolin cmdcolin deleted the fix_eslint_plugin_import branch October 6, 2021 23:48
@cmdcolin cmdcolin added enhancement New feature or request and removed bug Something isn't working labels Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add method to ensure @jbrowse/react-linear-genome-view has proper package.json dependencies
1 participant