-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No track menu options when changing alignments display to LinearPileupDisplay #1754
Comments
Just for brainstorming purposes, one option is to investigate this and fix it, probably worthwhile anyways Another option is actually to make a PileupTrack specialized track type, separate from AlignmentsTrack, and then LinearPileupDisplay would be registered to that instead of being selectable in the "Display types" section (similar for LinearSNPCoverageDisplay) |
Note: v1.0.3 did not experience this bug from what I can tell Also note: refreshing the page restores them |
Git bisect says 0b263b9 may have introduced the issue |
In some ways this is running into the limitations of https://mobx-state-tree.js.org/tips/inheritance We also lost the ability to set max score on SNPCoverage track, which was a nice benefit of SNPCoverageDisplay being derived from wiggle, but was lost when we defined a composedTrackMenuItems method on SNPCoverageDisplay, because that overrode the one from LinearWiggleDisplay |
Is this related to code using displays[0] hardcoded? There are quite a number of places in the code that does this now, and may need to be reigned in |
this was fixed I believe by the change to #2226 makes sense in a way :) the old "get trackMenuItems()" may not have accurately caught what was happening, which the new "trackMenuItems()" works |
Screenshot showing this
The text was updated successfully, but these errors were encountered: