-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use superRenderProps and superTrackMenuItems for better simulated inheritance model #2226
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2226 +/- ##
=======================================
Coverage 62.90% 62.90%
=======================================
Files 484 484
Lines 22728 22720 -8
Branches 5159 5154 -5
=======================================
- Hits 14297 14292 -5
+ Misses 8160 8158 -2
+ Partials 271 270 -1
Continue to review full report at Codecov.
|
requested @elliothershberg for review, similar concept to the menuItems getter to menuItems function change that was done in the bookmarks PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree this way of doing the track menu items feels better.
Fixes #2222