Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use superRenderProps and superTrackMenuItems for better simulated inheritance model #2226

Merged
merged 10 commits into from
Aug 18, 2021

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Aug 13, 2021

Fixes #2222

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Aug 13, 2021
@cmdcolin cmdcolin changed the title Use superRenderProps and superTrackMenuItems for better simulated inheriance model Use superRenderProps and superTrackMenuItems for better simulated inheritance model Aug 13, 2021
@codecov
Copy link

codecov bot commented Aug 14, 2021

Codecov Report

Merging #2226 (bf455f0) into main (aad6c52) will increase coverage by 0.00%.
The diff coverage is 81.16%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2226   +/-   ##
=======================================
  Coverage   62.90%   62.90%           
=======================================
  Files         484      484           
  Lines       22728    22720    -8     
  Branches     5159     5154    -5     
=======================================
- Hits        14297    14292    -5     
+ Misses       8160     8158    -2     
+ Partials      271      270    -1     
Impacted Files Coverage Δ
...c/BaseChordDisplay/models/BaseChordDisplayModel.ts 73.46% <0.00%> (ø)
...gins/filtering/src/LinearFilteringDisplay/model.js 4.76% <0.00%> (-0.24%) ⬇️
...arative-view/src/LinearComparativeDisplay/index.ts 5.88% <0.00%> (ø)
...comparative-view/src/LinearSyntenyDisplay/index.ts 25.00% <0.00%> (ø)
...roducts/jbrowse-desktop/src/sessionModelFactory.ts 11.90% <0.00%> (ø)
...omparative-view/src/LinearComparativeView/model.ts 7.52% <50.00%> (-1.95%) ⬇️
...ments/src/LinearSNPCoverageDisplay/models/model.ts 66.66% <76.47%> (+0.70%) ⬆️
.../pluggableElementTypes/models/BaseDisplayModel.tsx 76.19% <100.00%> (ø)
...ore/pluggableElementTypes/models/BaseTrackModel.ts 33.72% <100.00%> (+0.76%) ⬆️
packages/core/util/tracks.ts 66.66% <100.00%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aad6c52...bf455f0. Read the comment docs.

@cmdcolin cmdcolin marked this pull request as ready for review August 14, 2021 03:54
@cmdcolin
Copy link
Collaborator Author

requested @elliothershberg for review, similar concept to the menuItems getter to menuItems function change that was done in the bookmarks PR

@cmdcolin cmdcolin removed the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Aug 16, 2021
Copy link
Collaborator

@garrettjstevens garrettjstevens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this way of doing the track menu items feels better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert some getters into functions for proper inheritance simulation
3 participants