Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split alignments track menu items into "Pileup" and "SNPCoverage" submenus #1756

Merged
merged 5 commits into from
Mar 4, 2021

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Mar 3, 2021

This was sort of inspired by #1754 but does not fix it

I split the long list of track menu items for the combined snpcov+pileup alignments track into submenus, one for pileup, one for snpcoverage options

It also added a custom getter called "extraTrackMenuItems" instead of overriding composedTrackMenuItems in the SNPCoverageDisplay model because it was not possible to properly override composedTrackMenuItems and preserve the wiggle options

localhost_3001__config=test_data%2Fvolvox%2Fconfig json session=local-QB2XB3ssB (1)

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Mar 3, 2021
@cmdcolin
Copy link
Collaborator Author

cmdcolin commented Mar 3, 2021

This also removes SNPCoverage model's overriding of the renderProps function as the base version on LinearWiggleDisplay works ok for it

@cmdcolin cmdcolin added the enhancement New feature or request label Mar 3, 2021
@cmdcolin cmdcolin force-pushed the alignments_track_menu_updates branch from 13e228f to 080795d Compare March 3, 2021 01:38
@cmdcolin cmdcolin removed the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Mar 3, 2021
@cmdcolin cmdcolin force-pushed the alignments_track_menu_updates branch from 080795d to ef4f11a Compare March 3, 2021 01:46
@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #1756 (82a8ab2) into master (4de4374) will decrease coverage by 0.01%.
The diff coverage is 59.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1756      +/-   ##
==========================================
- Coverage   58.80%   58.79%   -0.02%     
==========================================
  Files         454      454              
  Lines       21007    21018      +11     
  Branches     4975     4979       +4     
==========================================
+ Hits        12354    12357       +3     
- Misses       8343     8352       +9     
+ Partials      310      309       -1     
Impacted Files Coverage Δ
...nments/src/LinearAlignmentsDisplay/models/model.ts 67.60% <ø> (ø)
...lugins/alignments/src/LinearPileupDisplay/model.ts 69.02% <ø> (ø)
...nts/src/SNPCoverageRenderer/SNPCoverageRenderer.ts 91.25% <12.50%> (-8.75%) ⬇️
...ins/wiggle/src/LinearWiggleDisplay/models/model.ts 72.38% <20.00%> (+0.88%) ⬆️
...ments/src/LinearSNPCoverageDisplay/models/model.ts 69.23% <76.47%> (ø)
...inearGenomeView/components/RefNameAutocomplete.tsx 89.36% <0.00%> (-4.26%) ⬇️
packages/core/util/index.ts 82.20% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4de4374...82a8ab2. Read the comment docs.

@cmdcolin cmdcolin merged commit a7a0a70 into master Mar 4, 2021
@cmdcolin cmdcolin deleted the alignments_track_menu_updates branch March 4, 2021 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant