Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAuth flow with assembly loading #3194

Closed
cmdcolin opened this issue Sep 16, 2022 · 1 comment
Closed

OAuth flow with assembly loading #3194

cmdcolin opened this issue Sep 16, 2022 · 1 comment

Comments

@cmdcolin
Copy link
Collaborator

Currently, there still could be an issue if user:

  • logs in
  • open a view
  • open track
  • leave the app until token expires
  • go directly to the assembly selection page in linear view

This may result in an error, but now refreshing the page after this error at least will request a new token.

Originally posted by @andrzejgrzelak in #3175 (comment)
@cmdcolin cmdcolin mentioned this issue Sep 16, 2022
Merged
andrzejgrzelak pushed a commit to andrzejgrzelak/jbrowse-components that referenced this issue Jan 18, 2023
Workaround of GMOD#3194, when not in web worker. Now refreshing page …
02acc70 
…does help when there was a token present but refresh token was not found.
@cmdcolin cmdcolin mentioned this issue Jan 24, 2023
Closed
@andrzejgrzelak andrzejgrzelak mentioned this issue Feb 8, 2023
Closed
garrettjstevens pushed a commit that referenced this issue Mar 13, 2023
@garrettjstevens
Workaround of #3194, when not in web worker. Now refreshing page does…
7f62be1 
… help when there was a token present but refresh token was not found.
cmdcolin added a commit that referenced this issue Jun 7, 2023
@garrettjstevens @cmdcolin
Add OAuth and HTTP BasicAuth servers for local testing, fix some OAut…
b321e7e 
…h flows (#3572)

* Workaround of #3194, when not in web worker. Now refreshing page does help when there was a token present but refresh token was not found.

* Make refresh token not found message more clear.

* Remove jwt-decode from OAuth validateToken

Tokens are not guaranteed to be JWT, so instead validate with a HEAD
request

* OAuth flow improvements

* Add OAuth and HTTP BasicAuth servers for local testing (#3742)

* Only mutate the loc.preauth info if not using MainThreadRpcDriver

* Move files around, add http basic auth test

* Use published version of @node-oauth/express-oauth-server

---------

Co-authored-by: grzelaka <andrzej.grzelak@contractors.roche.com>
Co-authored-by: Colin <colin.diesh@gmail.com>
@cmdcolin
Copy link
Collaborator Author

cmdcolin commented Jun 8, 2023

I think after latest work on oauth this can be closed!

@cmdcolin cmdcolin closed this as completed Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cmdcolin