Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spreadsheet filter support for derived columns #1530

Merged
merged 1 commit into from
Dec 7, 2020
Merged

Conversation

elliothershberg
Copy link
Member

#1158 introduced derived columns for BED and VCF files. This caused issues with the filtering functionality in the spreadsheet. This PR adds minor fixes to add support for filtering the spreadsheet using these derived columns.

Copy link
Contributor

@rbuels rbuels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's nice and simple. I seem to remember the reason we didn't do this in the first place was for performance, but I guess now that it's paginated I guess that isn't much of a concern anymore.

@codecov
Copy link

codecov bot commented Dec 7, 2020

Codecov Report

Merging #1530 (b700a12) into master (5b0a7de) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1530   +/-   ##
=======================================
  Coverage   59.46%   59.46%           
=======================================
  Files         435      435           
  Lines       19515    19513    -2     
  Branches     4555     4553    -2     
=======================================
  Hits        11604    11604           
+ Misses       7612     7610    -2     
  Partials      299      299           
Impacted Files Coverage Δ
...view/src/SpreadsheetView/components/Spreadsheet.js 31.95% <ø> (+0.64%) ⬆️
...c/SpreadsheetView/models/ColumnDataTypes/Number.js 24.28% <0.00%> (ø)
...src/SpreadsheetView/models/ColumnDataTypes/Text.js 33.33% <0.00%> (ø)
...-view/src/SpreadsheetView/models/FilterControls.ts 20.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b0a7de...b700a12. Read the comment docs.

@cmdcolin
Copy link
Collaborator

cmdcolin commented Dec 7, 2020

lgtm

@cmdcolin cmdcolin merged commit 221c8ba into master Dec 7, 2020
@cmdcolin cmdcolin deleted the spreadsheet_fix branch December 7, 2020 20:16
@elliothershberg elliothershberg added the enhancement New feature or request label Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants