Fix for navigation past end of chromosome

[cmdcolin]

Fixes #1718

This adds a redundancy that avoids an all out crash, and then fixes the navigation so it clamps to the end of the newly navigating displayed region

This is just a general observation but our logic for navigating is fairly complex...I think it is likely that a refactoring probably along the time that name indexing comes around is likely in order

[codecov]

Codecov Report

Merging #1719 (0c0422a) into master (31ce25f) will increase coverage by 0.01%.
The diff coverage is 70.00%.

@@            Coverage Diff             @@
##           master    #1719      +/-   ##
==========================================
+ Coverage   58.81%   58.82%   +0.01%     
==========================================
  Files         448      448              
  Lines       20754    20760       +6     
  Branches     4919     4922       +3     
==========================================
+ Hits        12206    12212       +6     
  Misses       8241     8241              
  Partials      307      307              

Impacted Files	Coverage Δ
...me-view/src/LinearGenomeView/components/Header.tsx	81.57% <55.55%> (ø)
...s/linear-genome-view/src/LinearGenomeView/index.ts	83.77% <80.00%> (-0.07%)	⬇️
...c/LinearGenomeView/components/OverviewScaleBar.tsx	91.89% <83.33%> (-1.17%)	⬇️
...inearGenomeView/components/RefNameAutocomplete.tsx	93.61% <0.00%> (+4.25%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31ce25f...0c0422a. Read the comment docs.

[rbuels]

looks ok to me, but I'm not all that up on LGV navigation. @teresam856 what do you think of this, and of @cmdcolin comment that navigation probably needs some refactoring

but anyway, ok with me to merge once @teresam856 weighs in on it

[teresam856]

Fixes #1718

This adds a redundancy that avoids an all out crash, and then fixes the navigation so it clamps to the end of the newly navigating displayed region

This is just a general observation but our logic for navigating is fairly complex...I think it is likely that a refactoring probably along the time that name indexing comes around is likely in order

I agree. I think navigation handles a lot of different cases right now. The changes lgtm but like Colin mentioned, I think a refactor may be needed to break up those actions.

[teresam856]

lgtm