Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add requestidlecallback ponyfill in @jbrowse/core/util #1762

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Mar 3, 2021

Added a really basic rIC ponyfill that performs setTimeout(cb,1) for @jbrowse/core/util, used it throughout the codebase where needed

The alternative I can think of is adding the requestidlecallback-polyfill to jbrowse-react-linear-genome-view specifically but probably just better to do this
https://github.com/GMOD/jbrowse-components/tree/ric_polyfill

For compatibility with Safari mostly

Fixes #1659

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Mar 3, 2021
@cmdcolin cmdcolin changed the title Add requestidlecallback ponyfill to point of use in LGV Add requestidlecallback ponyfill in @jbrowse/core/util for use in codebase Mar 3, 2021
@cmdcolin cmdcolin removed the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Mar 3, 2021
@cmdcolin cmdcolin changed the title Add requestidlecallback ponyfill in @jbrowse/core/util for use in codebase Add requestidlecallback ponyfill in @jbrowse/core/util Mar 3, 2021
@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Mar 4, 2021
@codecov
Copy link

codecov bot commented Mar 4, 2021

Codecov Report

Merging #1762 (03319bb) into master (6f27b40) will increase coverage by 0.00%.
The diff coverage is 88.88%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1762   +/-   ##
=======================================
  Coverage   58.74%   58.74%           
=======================================
  Files         455      455           
  Lines       21033    21038    +5     
  Branches     4979     4983    +4     
=======================================
+ Hits        12355    12358    +3     
- Misses       8368     8370    +2     
  Partials      310      310           
Impacted Files Coverage Δ
packages/core/util/index.ts 82.42% <75.00%> (+0.22%) ⬆️
...BaseChordDisplay/components/RpcRenderedSvgGroup.js 93.75% <100.00%> (+0.20%) ⬆️
...ins/dotplot-view/src/ServerSideRenderedContent.tsx 84.21% <100.00%> (ø)
...arDisplay/components/ServerSideRenderedContent.tsx 90.00% <100.00%> (ø)
...inearGenomeView/components/RefNameAutocomplete.tsx 89.36% <0.00%> (-4.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f27b40...84ed79e. Read the comment docs.

@cmdcolin cmdcolin added internal and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Mar 4, 2021
@cmdcolin cmdcolin merged commit 1c8a902 into master Mar 4, 2021
@cmdcolin cmdcolin deleted the ric_ponyfill branch March 4, 2021 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@jbrowse/react-linear-genome-view crash on Safari: ReferenceError: Can't find variable: requestIdleCallback
1 participant