Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show modified bases using MM and MP/ML tags in BAM/CRAM #1865

Merged
merged 64 commits into from May 18, 2021
Merged

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Apr 1, 2021

Stub for coloring reads that have MM (positions of modified bases) and MP/ML (modification likelihood/probability) tags

This can be used to show methylation and other types of modifications, but methylation is probably the most common application

https://github.com/GMOD/jbrowse/issues/1588

Needs to still incorporate CIGAR for positioning, but this is a fun start

Requested here https://github.com/GMOD/jbrowse/issues/1588

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Apr 1, 2021
@cmdcolin
Copy link
Collaborator Author

cmdcolin commented Apr 1, 2021

Note that to do this properly, it is probably useful for SNPCoverage to also show these modification in the pileup too

@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Apr 2, 2021
@cmdcolin
Copy link
Collaborator Author

cmdcolin commented Apr 7, 2021

Other todos:

  • incorporate into snpcoverage renderer/adapter
  • dynamically set color palette for different modifications (similar to our color by tag functionality)
  • allow only drawing a single modification type at a time perhaps
  • possibly draw multiple modifications at a single base pair

@cmdcolin
Copy link
Collaborator Author

cmdcolin commented Apr 7, 2021

possibly also making the wgbs type display could be worth doing in parallel, as some modern tools for calling modifications output pseudo-wgbs mode bam files https://software.broadinstitute.org/software/igv/interpreting_bisulfite_mode

@cmdcolin cmdcolin marked this pull request as ready for review May 5, 2021 17:11
Copy link
Contributor

@rbuels rbuels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just a couple little questions

package.json Outdated Show resolved Hide resolved
plugins/alignments/package.json Outdated Show resolved Hide resolved
@rbuels rbuels merged commit 969e535 into main May 18, 2021
@rbuels rbuels deleted the methylation branch May 18, 2021 18:11
@garrettjstevens
Copy link
Collaborator

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants