Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create extension point example #2124

Closed
wants to merge 2 commits into from
Closed

Conversation

elliothershberg
Copy link
Member

This is something I worked on with @rbuels today. It is one possible implementation for #2032 .

This example relates to the problems I was having with data in the widget model not persisting in #2080, but it turns out that might not be necessary.

However, this type of system could be used in other areas for that PR to remove some of the code updating the LGV plugin.

cc @garrettjstevens

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jul 12, 2021
@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #2124 (8a0912b) into main (b223419) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2124   +/-   ##
=======================================
  Coverage   62.02%   62.03%           
=======================================
  Files         476      476           
  Lines       22789    22808   +19     
  Branches     5350     5353    +3     
=======================================
+ Hits        14134    14148   +14     
- Misses       8374     8379    +5     
  Partials      281      281           
Impacted Files Coverage Δ
packages/core/PluginManager.ts 94.49% <100.00%> (+0.34%) ⬆️
plugins/linear-genome-view/src/index.ts 92.59% <100.00%> (+1.28%) ⬆️
products/jbrowse-web/src/sessionModelFactory.ts 59.20% <100.00%> (+0.12%) ⬆️
...nts/src/SNPCoverageRenderer/SNPCoverageRenderer.ts 80.24% <0.00%> (-7.41%) ⬇️
packages/core/util/index.ts 79.89% <0.00%> (ø)
packages/core/util/analytics.ts 93.02% <0.00%> (+2.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b223419...8a0912b. Read the comment docs.

@cmdcolin
Copy link
Collaborator

cmdcolin commented Jul 13, 2021

interesting stuff...this still in some sense puts a burden on consumers (e.g. jbrowse-web, jbrowse-desktop, embedded) to properly evaluate extension points, and because they are very much stringly/dynamically defined, it is hard to know whether you would evaluate the right ones

@cmdcolin
Copy link
Collaborator

since we do have expectations about which things should be evaluated where, it seems like we could make more hardcoded assumptions

@elliothershberg elliothershberg deleted the extension_points branch July 19, 2021 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants