-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import bookmarks functionality for grid bookmark widget #2243
Conversation
f80b423
to
4a1284f
Compare
4a1284f
to
ba63dfc
Compare
Codecov Report
@@ Coverage Diff @@
## main #2243 +/- ##
==========================================
- Coverage 62.88% 62.84% -0.05%
==========================================
Files 493 494 +1
Lines 22907 22942 +35
Branches 5178 5191 +13
==========================================
+ Hits 14405 14417 +12
- Misses 8236 8258 +22
- Partials 266 267 +1
Continue to review full report at Codecov.
|
d9924e5
to
f8244d8
Compare
Nice! I'll take a look at this soon and give it a spin locally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good! I added a few points about the import form, but other than that I think this is a good addition to bookmarks.
plugins/grid-bookmark/src/GridBookmarkWidget/components/DeleteBookmark.tsx
Outdated
Show resolved
Hide resolved
plugins/grid-bookmark/src/GridBookmarkWidget/components/ImportBookmarks.tsx
Outdated
Show resolved
Hide resolved
plugins/grid-bookmark/src/GridBookmarkWidget/components/ImportBookmarks.tsx
Show resolved
Hide resolved
f8244d8
to
ccdf6d5
Compare
3a7d44a
to
6ff4aac
Compare
thanks for the review @elliothershberg :) big 🥳 for the bookmark feature as a whole |
I had a quick interest in getting a import bookmarks function implemented
This let's a user quickly import a BED formatted file. The name column 4 is stored in the "label" field
It also has a couple more add-ons
Some motivation to this includes my feeling that you can easily loose track of your session
During development especially, I cycle through tons of sessions and I imagine a user may also, and if we're not careful, we would loose our bookmarks (since bookmarks are currently tied to session...). So if we can at least re-import them, it seems useful
Just an idea I picked up and ran with :)