-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release announcement draft v1.4.0 #2300
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2300 +/- ##
==========================================
- Coverage 61.92% 61.92% -0.01%
==========================================
Files 511 511
Lines 23296 23296
Branches 5333 5333
==========================================
- Hits 14427 14426 -1
- Misses 8601 8602 +1
Partials 268 268
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They should be backwards compatible ....unless we decide we need typed arrays for #2289 (e.g. whole note field instead of just the keyword in the note field that matched) I'd be ok to delay release to make sure that is ironed out |
Ok. @garrettjstevens @cmdcolin Yeah I think it's good idea to delay. We can release once #2296, #2301 ,and maybe #2303 go in. These three affect the the trix files. Will get to #2301 today.
|
…claimer about jbrowse-desktop
I believe we have stabalized the trix format, it resulted actually in no actual change to the format but now allows more than name and id to be serialized. it is actually literally the fields from --attributes that are serialized into the record e.g. [locString,trackId,...attributes] by putting all attributes, we can possibly match rich context such as a note attribute. the driver case is e.g. I type kinase on the volvox example, the search result can give me gene name and description EDEN (protein kinase) or if it's a long description, it is excerpted and ellipses'd) EDEN (...something something kinase ....) it is not currently implemented as a typed array. typed array could allow e.g. a thing like advanced google searches where the fieldname:searchterm is specified but i think we can ship without this for now and i believe we could extend our current format to allow this in the future also (a type id could be part of the record e.g. [locString,trackId,typeId,...typedarray] |
final review welcome. try config_demo and volvox demos...links below will be ready soon large dataset with many dbsnp IDshttps://jbrowse.org/code/jb2/main/index.html?config=test_data/config_demo.json supports description searchinghttps://jbrowse.org/code/jb2/main/index.html?config=test_data/volvox/config.json |
Add note that text searching is pluggable
Unreleased (2021-09-07)
🚀 Enhancement
core
jbrowse text-index
CLI command to generate trix index (@teresam856)🐛 Bug Fix
core
📝 Documentation
🏠 Internal
Committers: 3