Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release announcement draft v1.4.0 #2300

Merged
merged 4 commits into from
Sep 13, 2021
Merged

Release announcement draft v1.4.0 #2300

merged 4 commits into from
Sep 13, 2021

Conversation

teresam856
Copy link
Contributor

Unreleased (2021-09-07)

🚀 Enhancement

  • Other
    • #2287 Use react-popper to reduce tooltip lag on pages with many elements (@cmdcolin)
    • #2294 Don't rely on SVTYPE=BND for breakend split view options and thicker mouseover chords on circular views (@cmdcolin)
    • #2272 Auto adjust box RefNameAutocomplete width based on refName length (@cmdcolin)
    • #2243 Import bookmarks functionality for grid bookmark widget (@cmdcolin)
  • core
    • #2247 New jbrowse-desktop start screen design (@cmdcolin)
    • #2254 Better error reporting from web worker and chrom sizes adapter errors (@cmdcolin)
    • #1881 Add new text searching functionality to core, with jbrowse text-index CLI command to generate trix index (@teresam856)

🐛 Bug Fix

  • Other
    • #2283 Fix ability for the variant detail panel to create breakpoint split view for elements (@cmdcolin)
    • #2268 Fix autocomplete height on small displays (@cmdcolin)
  • core
    • #2250 Prevent the ToggleButton for the FileSelector toggling to local file when only URL should be available (@cmdcolin)

📝 Documentation

  • #2290 Updates user guide docs to show text searching example (@teresam856)
  • #2253 Add note about legacy-peer-deps to readme (@cmdcolin)
  • #2262 Add more MDX documentation pages to @jbrowse/react-linear-genome-view storybooks (@cmdcolin)

🏠 Internal

Committers: 3

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Sep 7, 2021
@teresam856 teresam856 added documentation and removed documentation needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Sep 7, 2021
@teresam856 teresam856 self-assigned this Sep 7, 2021
@codecov
Copy link

codecov bot commented Sep 7, 2021

Codecov Report

Merging #2300 (214937b) into main (82f1318) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2300      +/-   ##
==========================================
- Coverage   61.92%   61.92%   -0.01%     
==========================================
  Files         511      511              
  Lines       23296    23296              
  Branches     5333     5333              
==========================================
- Hits        14427    14426       -1     
- Misses       8601     8602       +1     
  Partials      268      268              
Impacted Files Coverage Δ
packages/core/assemblyManager/assemblyManager.ts 67.10% <0.00%> (-1.32%) ⬇️
packages/core/util/index.ts 79.84% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82f1318...214937b. Read the comment docs.

Copy link
Collaborator

@garrettjstevens garrettjstevens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should be v1.4.0?

Also, are we sure #2289 and #2296 will be backward compatible? If not, I think delaying a couple days until those are done would be worth it.

website/release_announcement_drafts/v1.3.6.md Outdated Show resolved Hide resolved
@cmdcolin
Copy link
Collaborator

cmdcolin commented Sep 7, 2021

They should be backwards compatible ....unless we decide we need typed arrays for #2289 (e.g. whole note field instead of just the keyword in the note field that matched)

I'd be ok to delay release to make sure that is ironed out

@teresam856
Copy link
Contributor Author

teresam856 commented Sep 7, 2021

Ok. @garrettjstevens @cmdcolin Yeah I think it's good idea to delay. We can release once #2296, #2301 ,and maybe #2303 go in. These three affect the the trix files. Will get to #2301 today.

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Sep 7, 2021
@cmdcolin cmdcolin changed the title Release announcement draft v1.3.6 Release announcement draft v1.4.0 Sep 8, 2021
@teresam856 teresam856 added documentation and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Sep 8, 2021
@cmdcolin
Copy link
Collaborator

I believe we have stabalized the trix format, it resulted actually in no actual change to the format but now allows more than name and id to be serialized. it is actually literally the fields from --attributes that are serialized into the record e.g.

[locString,trackId,...attributes]

by putting all attributes, we can possibly match rich context such as a note attribute. the driver case is e.g. I type kinase on the volvox example, the search result can give me gene name and description

EDEN (protein kinase)

or if it's a long description, it is excerpted and ellipses'd)

EDEN (...something something kinase ....)

it is not currently implemented as a typed array. typed array could allow e.g. a thing like advanced google searches where the fieldname:searchterm is specified but i think we can ship without this for now and i believe we could extend our current format to allow this in the future also (a type id could be part of the record e.g. [locString,trackId,typeId,...typedarray]

@cmdcolin
Copy link
Collaborator

final review welcome. try config_demo and volvox demos...links below will be ready soon

large dataset with many dbsnp IDs

https://jbrowse.org/code/jb2/main/index.html?config=test_data/config_demo.json

supports description searching

https://jbrowse.org/code/jb2/main/index.html?config=test_data/volvox/config.json

Add note that text searching is pluggable
@teresam856 teresam856 merged commit 87c64d9 into main Sep 13, 2021
@cmdcolin cmdcolin deleted the text_searching_release branch September 14, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants