New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to access authenticated resources using pluggable internet accounts framework #2279
Conversation
…oad a file from dropbox
…dicators for connected
…lugin, will make new branch with just plugin logic tomorrow to mvoe away from hardcoding endpoints
…pp with plugin and allowing for custom headers with auth token
…nCreate creates an internetaccountmodel for each internet account in the config
…he rootmodel, fix some logic
…oken from storage if it exists instead of always opening flow, add model for existingtoken flow i.e GDC
…google and others, continue working on externaltoken model
…getBlob so accessToken can be passed to webworker, next need to replace existing openlocations with the rootmodel one
…cmethodtypes to pass the token, eventually can move specific code out of addtrackwidget and add here
…ddtrackwidget, this should also allow for hand editing
…piration to try refresh token or log in, add in more refreshtoken logic, once things are smoothed over can move on to external token model and done with Oauth
random thing to note: the file selector for the "Open sequence" dialog will not be able to access authenticated resources on jbrowse desktop from it's start screen. no pluginmanager exists at the startscreen as is. if we needed to, we could maybe make a blank rootmodel or something of this sort to assist |
Predefined google and dropbox authentication on desktop
I had the redirect uri for the main branch but had removed the redirect uri for this specific branch so that's why there was a mismatched |
Thanks for catching that, I fixed it on the web rootmodel but forgot to sync over the changes to the desktop rootmodel too |
While pairing with @garrettjstevens , realized that OAuth Authentication was not working on production jbrowse-desktop since the window.location is a Dropbox seemed to stop working on desktop and web, it seems to have been broken even before these changes. We suspect it may have something to do with dropbox servers, since it was working for me on Friday without any changes to the code, and since there has been issues with various internet services being down today, we are going to double check tomorrow to see if it's a dropbox server issue or an actual issue with the code before merging |
…use desktop specific OAuth apps
Can we avoid the change to the data adapter constructor prototype? This change would, for example, break the quantseq plugin which uses getSubAdapter |
will be moving pluginManager to the third param and making it optional |
…meter so it is not a breaking change
@cmdcolin when you have some time could you check out the changes in the latest commit (moving pm to optional and the third parameter) to make sure I did it correctly + it won't break older plugins now |
This feature adds internet accounts to JBrowse 2 for use with authentication. This initially comes with support for 4 methods