Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jbrowse-img to monorepo #2336

Merged
merged 5 commits into from
Sep 22, 2021
Merged

Add jbrowse-img to monorepo #2336

merged 5 commits into from
Sep 22, 2021

Conversation

cmdcolin
Copy link
Collaborator

This is a proposal to add jbrowse-img to the monorepo. Benefits would be better testing, less likely to experience random breakage, etc.

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Sep 15, 2021
@cmdcolin
Copy link
Collaborator Author

Maybe for now marked as draft but tests pass and should be fundamentally ok to use

Note one item is that jbrowse-img depends on jbrowse-react-linear-genome-view, so it actually needs to build jbrowse-react-linear-genome-view to run (unless we want to toggle between dist/src in package.json like plugins do)

Alternatively, we could make jbrowse-img not depend on jbrowse-react-linear-genome-view, it only uses the createViewState part

@cmdcolin cmdcolin marked this pull request as draft September 15, 2021 20:21
@cmdcolin cmdcolin added internal discuss in meeting and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Sep 15, 2021
@rbuels
Copy link
Contributor

rbuels commented Sep 22, 2021

sounds good to me, i think just go ahead and merge when ready

@codecov
Copy link

codecov bot commented Sep 22, 2021

Codecov Report

Merging #2336 (f1f7d8c) into main (e07b309) will increase coverage by 0.40%.
The diff coverage is 52.17%.

❗ Current head f1f7d8c differs from pull request most recent head f1bfe69. Consider uploading reports for the commit f1bfe69 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2336      +/-   ##
==========================================
+ Coverage   61.86%   62.27%   +0.40%     
==========================================
  Files         511      516       +5     
  Lines       23414    23598     +184     
  Branches     5433     5500      +67     
==========================================
+ Hits        14486    14696     +210     
+ Misses       8660     8613      -47     
- Partials      268      289      +21     
Impacted Files Coverage Δ
products/jbrowse-img/src/bin.js 0.00% <0.00%> (ø)
products/jbrowse-img/src/index.js 0.00% <0.00%> (ø)
products/jbrowse-img/src/renderRegion.js 61.02% <61.02%> (ø)
products/jbrowse-img/src/parseArgv.js 63.15% <63.15%> (ø)
products/jbrowse-img/src/util.js 100.00% <100.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e07b309...f1bfe69. Read the comment docs.

@cmdcolin cmdcolin marked this pull request as ready for review September 22, 2021 19:14
… testPathIgnorePatterns which then drops any additional positional args to yarn test
@cmdcolin cmdcolin merged commit dc2ba6e into main Sep 22, 2021
@cmdcolin cmdcolin deleted the jb2export_product branch September 22, 2021 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants