-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jbrowse-img to monorepo #2336
Conversation
Maybe for now marked as draft but tests pass and should be fundamentally ok to use Note one item is that jbrowse-img depends on jbrowse-react-linear-genome-view, so it actually needs to build jbrowse-react-linear-genome-view to run (unless we want to toggle between dist/src in package.json like plugins do) Alternatively, we could make jbrowse-img not depend on jbrowse-react-linear-genome-view, it only uses the createViewState part |
sounds good to me, i think just go ahead and merge when ready |
876f694
to
df78dba
Compare
Codecov Report
@@ Coverage Diff @@
## main #2336 +/- ##
==========================================
+ Coverage 61.86% 62.27% +0.40%
==========================================
Files 511 516 +5
Lines 23414 23598 +184
Branches 5433 5500 +67
==========================================
+ Hits 14486 14696 +210
+ Misses 8660 8613 -47
- Partials 268 289 +21
Continue to review full report at Codecov.
|
df78dba
to
ab26a56
Compare
… testPathIgnorePatterns which then drops any additional positional args to yarn test
13f893e
to
f1bfe69
Compare
This is a proposal to add jbrowse-img to the monorepo. Benefits would be better testing, less likely to experience random breakage, etc.