Fix embedded crash when opening dialogs

[garrettjstevens]

Fixes #2466

This doesn't update the babel configuration (I tried that without any luck), but changes the code to avoid what is probably a weird bug in babel. It makes the volatile queueOfDialogs array not observable, and re-assigns the variable each time it's altered so the volatile's top-level observability is sufficient.

Came up with this with @cmdcolin during a pairing.

[codecov]

Codecov Report

Merging #2469 (140be8a) into main (473b37b) will increase coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2469      +/-   ##
==========================================
+ Coverage   61.15%   61.18%   +0.03%     
==========================================
  Files         539      539              
  Lines       25072    25076       +4     
  Branches     5858     5858              
==========================================
+ Hits        15332    15343      +11     
+ Misses       9422     9415       -7     
  Partials      318      318              

Impacted Files	Coverage Δ
...-genome-view/src/createModel/createSessionModel.ts	11.39% <0.00%> (-0.15%)	⬇️
...-genome-view/src/createModel/createSessionModel.ts	18.75% <0.00%> (-0.24%)	⬇️
packages/core/TextSearch/TextSearchManager.ts	100.00% <0.00%> (+3.44%)	⬆️
...inearGenomeView/components/RefNameAutocomplete.tsx	86.02% <0.00%> (+10.75%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 473b37b...140be8a. Read the comment docs.

[rbuels]

Are the storybooks sufficient to test if this is still happening? Trying to figure out if I need to include this in #3661

[cmdcolin]

I would consider observable arrays in a volatile to be overcomplicating things so I would keep it as is, and it may not be caught by tests (would have to be a component_tests/lgv probably to test the built products)

[rbuels]

It isn't currently like this in desktop or web, do you think that implementation would work in desktop and web?

…

On Thu, Apr 27, 2023 at 10:02 AM Colin Diesh ***@***.***> wrote: I would consider observable arrays in a volatile to be overcomplicating things so I would keep it as is, and it may not be caught by tests (would have to be a component_tests/lgv probably to test the built products) — Reply to this email directly, view it on GitHub <#2469 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAASAFJJH57LYGUT3BARLUDXDKRADANCNFSM5G54RBUA> . You are receiving this because you commented.Message ID: ***@***.***>

[cmdcolin]

ya should be fine to unify across products (either nonobservable.array or observer, nonobserver should be fine though and we can audit usages of observer if it is helpful)